Add API to sort array of custom objects #103
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lib/x86simdsort.h
Outdated
| #define UNUSED(x) (void)(x) | ||
|
|
||
| template <typename T> | ||
| XSS_HIDE_SYMBOL void permute_array_in_place(T *A, std::vector<size_t> P) |
There was a problem hiding this comment.
Move to an x86simdsort::detail namespace.
Take the P parameter by const-reference or change the call site to use std::move(arg).
Comment on lines
+58
to
+50
| using return_type_of = | ||
| typename decltype(std::function {key_func})::result_type; |
There was a problem hiding this comment.
This is probably a C++17 technique (CTAD). If you need to support pre-C++17, you may need to rewrite it.
| { | ||
| using return_type_of = | ||
| typename decltype(std::function {key_func})::result_type; | ||
| std::vector<return_type_of> keys; |
lib/x86simdsort.h
Outdated
|
|
||
| // sort an object | ||
| template <typename T, typename F> | ||
| XSS_EXPORT_SYMBOL void object_qsort(T *arr, size_t arrsize, const F key_func) |
There was a problem hiding this comment.
This would be more idiomatic in C++ if you did:
template <typename It, typename F> void object_qsort(It begin, It end, F &&key_func)
{
using T = typename std::iterator_traits<It>::value_type;
#if __cplusplus >= 201703L
using R = std::invoke_result_t<F, T>;
#else
using R = std::result_of_t<F>;
#endif
std::vector<R> keys;
keys.reserve(std::distance(begin, end));
for (auto it = first; it != end; ++it)
keys.emplace_back(key_func(*it));
r-devulap
force-pushed
the
customsort-expt
branch
from
e680504 to
fbc033e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Benchmarks sorting an array of 2D and 3D cartesian coordinates: